Always use FS representation of String when calling FS syscalls #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update calls to stat(), lstat(), access(), link(), unlink(), symlink(), readlink(), rename(), chmod(), mkdir() and chdir(). - Fix deallocating the fs representation in FileManager._lstatFile(withPath:) and URL.withUnsafeFileSystemRepresentation(). - Add FileManager._copySymlink(atPath:toPath:) to copy a symlink without the roundtrip via String.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
kperryua
approved these changes
May 2, 2018
There was a problem hiding this comment.
This all seems fine, but I wonder if it suggests that there's a bigger problem. Should Swift be allowing code to pass String to these file system APIs at all? Is it documented anywhere what normalization doing so results in?
In Objective-C, you obviously can't pass an NSString to lstat directly, so you're forced to at least think about how to convert to a C string. In Swift, there's nothing to make you think, which makes it easier for others to get this "wrong".
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update calls to stat(), lstat(), access(), link(), unlink(),
symlink(), readlink(), rename(), chmod(), mkdir() and chdir().
Fix deallocating the fs representation in FileManager._lstatFile(withPath:)
and URL.withUnsafeFileSystemRepresentation().
Add FileManager._copySymlink(atPath:toPath:) to copy a symlink
without the roundtrip via String.