[4.2] FileSystemRepresentation: Avoid leak and over early free. #2071
Conversation
- Fix deallocating the fs representation in FileManager._lstatFile(withPath:) and URL.withUnsafeFileSystemRepresentation(). (cherry picked from commit 38b155b)
|
@swift-ci test 4.2 |
1 similar comment
|
@swift-ci test 4.2 |
|
Are we planning to do any more 4.2 releases? @weissi? |
|
@ianpartridge probably one more, given that there are quite important outstanding fixes. The monthlies are finished for 4.2 so it won’t be regular but I think we should do one more. |
|
This is the last fix from me unless any new crashers are found in 4.2 |
|
@swift-ci test 4.2 |
|
@spevans this one failed CI |
|
Anyone know what |
CC @shahmishal / @compnerd / @millenomi |
|
I will fix that today, I did not know we were still taking changes on 4.2 branch. |
|
@weissi - yes, its a build cache tool developed by mozilla. |
|
@swift-ci test 4.2 |
1 similar comment
|
@swift-ci test 4.2 |
|
@swift-ci test 4.2 linux |
1 similar comment
|
@swift-ci test 4.2 linux |
Fix deallocating the fs representation in FileManager._lstatFile(withPath:)
and URL.withUnsafeFileSystemRepresentation().
This is a subset of the changes in Always use FS representation of String when calling FS syscalls #1540 just fixing 2 memory issues.
(cherry picked from commit 38b155b)