[windows] NSRecursiveLock: missing initialization of mutex/condition variable #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Um, no, no one would ever write code like that, this is ... yes, yes, something must be wrong with the checkout. sigh At least I got the non-recursive case right? That counts for something right? |
|
@swift-ci please test and merge |
compnerd
approved these changes
May 15, 2019
gottesmm
reviewed
May 15, 2019
| @@ -234,6 +234,8 @@ open class NSRecursiveLock: NSObject, NSLocking { | |||
| super.init() | |||
| #if os(Windows) | |||
| InitializeCriticalSection(mutex) | |||
| InitializeConditionVariable(timeoutCond) | |||
There was a problem hiding this comment.
Oh. Just realized there is no test for locks. It would be helpful for sure. Should I add test to this particular PR?
There was a problem hiding this comment.
Can you add it in a subsequent PR? My suggestion: I would add the test with this reverted, make sure it fails and then add this back in.
There was a problem hiding this comment.
Sounds good, will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like timeout condition variable and corresponding mutex are not initialized in
RSMRecursiveLockimplementation. Noticed random but often crashes in our test code. Best reproduced with nested lock/unlock callsNot sure if there is no additional issues though, still getting very rare crashes. But success rate changed from, like, "1 success per 100 failures" to "1 failure per 100 success runs".