Initialize pthread mutexes in NSRecursiveLock #2276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, having that in a single change is fine. |
|
@swift-ci please test |
|
Can you make the timeout looser? Maybe 30 seconds. Sometimes these machines get hit really hard. |
Sure. I think I need to add better timeout logic then, because current code waits 2 sec unconditionally. I'll change it to wait until all threads finish but not greater than timeout. |
compnerd
reviewed
May 17, 2019
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
I see, Linux build fails. Will look into that, guess I missed something in ifdefs. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to suggest a test for NSRecursiveLock fix in #2269, as promised. But test turned out extremely useful from first run. Found that pthread-based implementation is also missing some initialization.
I suppose it will be ok to add this new fix and test in one PR, right?