Support ICU 62+ #2436
Support ICU 62+ #2436
Conversation
|
@swift-ci test |
| @@ -1028,8 +1044,8 @@ class TestNumberFormatter: XCTestCase { | |||
| XCTAssertEqual(formatter.negativeFormat, "---#.##") | |||
|
|
|||
| formatter.positiveFormat = nil | |||
| XCTAssertEqual(formatter.positiveFormat, "#") | |||
| XCTAssertEqual(formatter.format, "#;000;---#.##") | |||
| //XCTAssertEqual(formatter.positiveFormat, "#") | |||
There was a problem hiding this comment.
Please do not leave commented code in? Either wrap it in shouldFail… or remove it.
|
I'm okay taking this if we use testExpectedToFail and do not ship with commented code. |
|
Also, what ICU are we shipping with? Is there an update cadence? |
|
I was just waiting for the automerge to 5.1 to be switched off - which it is now - to avoid this ending in 5.1 without the corresponding update to the swift repo. I will modify the tests to disable them, I will try and get them working again in the future as they work correctly on Darwin. I'll sort out a swift repo PR to update Linux to use ICU64.2 to test with this. |
spevans
force-pushed
the
pr_support_icu62
branch
2 times, most recently
from
9500ea2 to
01d35c6
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
- ICU 62.1 icu4c DecimalFormat api now wraps the new NumberFormatter api. - Update currency spacing according to ICU changes (http://bugs.icu-project.org/trac/ticket/6560) - Disable tests for converting Double.leastNonzeroMagnitude to a localised string, this is currently broken due to a bug in the underlying double-conversion library used by ICU. - Disable tests that allowed different patterns for negative numbers, http://icu-project.org/apiref/icu4c/classDecimalFormat.html states that negative patterns serve only to specify the negative prefix and suffix. The number of digits, minimal digits and other characteristics are ignored in the negative subpattern. - Support for different negative patterns may need to be added as a workaround in the future.
spevans
force-pushed
the
pr_support_icu62
branch
from
01d35c6 to
5d0e90e
Compare
|
@swift-ci test |
|
@swift-ci test linux |
|
https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=9515&view=logs&j=b9e62f99-1a98-5ed7-01d2-f4794231ed79&t=ed51126e-ea75-5eb0-f5c0-9c092583474a&l=4720 is a windows run that shows a lot of test improvement |
|
@swift-ci test |
|
The plan to upgrade ICU will be:
These PRs will be merged individually to avoid having to do cross repo simultaneous merges. |
|
@swift-ci test |
|
@swift-ci test and merge |
ICU 62.1 icu4c DecimalFormat api now wraps the new NumberFormatter
api.
Update currency spacing accoring to ICU changes
(http://bugs.icu-project.org/trac/ticket/6560)
Disable tests that allowed different patterns for negative numbers,
http://icu-project.org/apiref/icu4c/classDecimalFormat.html states
that negative patterns serve only to specify the negative prefix
and suffix. The number of digits, minimal digits and other
characteristics are ignored in the negative subpattern.
Support for different negative patterns may need to be added as a
workaround.