ICU: Update TestNumberFormatter tests to be compatible with ICU62+ and Darwin #2535
+118
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…d Darwin - ICU62+ changed how some of the NumberFormatter formats and properties work. These tests also work differently in the Foundation supported by macOS Catalina (10.15). - Update the tests to work correctly when run using DarwinCompatibilityTests on Catalina. - Update NumberFormatter to make the tests work correctly on Linux with ICU65.1
spevans
force-pushed
the
pr_icu_test_fixes
branch
from
6a8beee to
8d80ef9
Compare
|
Please test with the following PR @swift-ci test |
|
@swift-ci test |
spevans
changed the title
|
@swift-ci test and merge |
|
@swift-ci test macos |
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU62+ changed how some of the NumberFormatter formats and properties
work. These tests also work differently in the Foundation supported by
macOS Catalina (10.15).
Update the tests to work correctly when run using DarwinCompatibilityTests
on Catalina.
Update NumberFormatter to make the tests work correctly on Linux with
ICU65.1
Note: Do not merge until ICU has been updated to 65.1