build: restructure CoreFoundation build rules #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

compnerd merged 1 commit into swiftlang:master from compnerd:tessellating-patterns

Aug 24, 2019

Member

compnerd commented Aug 4, 2019

Reduce some of the unnecessary duplication in the CoreFoundation build.
This also reorganises the rules some to group the operations together.
There is more than can be done here to reduce duplication and simplify
the rules, but some of that work requires coordinating changes with
libdispatch and can be done subsequently.

Member Author

compnerd commented Aug 4, 2019

@swift-ci please test

Member Author

compnerd commented Aug 17, 2019

@swift-ci please test Linux platform

compnerd force-pushed the tessellating-patterns branch from d2e05e3 to 64be748 Compare

August 17, 2019 23:52

Member Author

compnerd commented Aug 17, 2019

@swift-ci please test

compnerd force-pushed the tessellating-patterns branch from 64be748 to cb1c3c2 Compare

August 23, 2019 16:55

Member Author

compnerd commented Aug 23, 2019

@swift-ci please test Linux platform

compnerd force-pushed the tessellating-patterns branch from cb1c3c2 to 7097167 Compare

August 23, 2019 18:47

Member Author

compnerd commented Aug 23, 2019

@swift-ci please test Linux platform

compnerd force-pushed the tessellating-patterns branch from 7097167 to 83ee318 Compare

August 23, 2019 20:27

Member Author

compnerd commented Aug 23, 2019

@swift-ci please test Linux platform


          build: restructure CoreFoundation build rules

e8fca9a

Reduce some of the unnecessary duplication in the CoreFoundation build.
This also reorganises the rules some to group the operations together.
There is more than can be done here to reduce duplication and simplify
the rules, but some of that work requires coordinating changes with
libdispatch and can be done subsequently.

compnerd force-pushed the tessellating-patterns branch from 83ee318 to e8fca9a Compare

August 23, 2019 23:12

Member Author

compnerd commented Aug 23, 2019

@swift-ci please test Linux platform

compnerd merged commit 0cc57d2 into swiftlang:master

compnerd deleted the tessellating-patterns branch

August 24, 2019 01:49

Contributor

beccadax commented Aug 24, 2019

@compnerd Swift CI is showing a lot of angry Linux bots with messages like:

CMake Error at CoreFoundation/CMakeLists.txt:2 (cmake_minimum_required):
  CMake 3.12 or higher is required.  You are running version 3.5.1

Contributor

spevans commented Aug 24, 2019

@brentdax do you have a link to a specific CI failure?

Contributor

spevans commented Aug 24, 2019

Looking at https://ci.swift.org/view/Packages/job/oss-swift-package-linux-ubuntu-16_04/3968/consoleFull I can't see the CMake repo actually being checked out.

Contributor

aschwaighofer commented Aug 26, 2019

Looks like this commit has caused some havoc with the linux builders:

https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/8014/
https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/10151/
...

aschwaighofer mentioned this pull request

Revert "build: restructure CoreFoundation build rules" #2489

Merged

Contributor

benlangmuir commented Aug 26, 2019

I can't see the CMake repo actually being checked out.

@shahmishal do we need to add cmake repo on these bots? It's in update-checkout, but maybe not in our ci setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet