Skip to content

Revert "build: restructure CoreFoundation build rules" #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

aschwaighofer
Copy link
Contributor

This reverts commit e8fca9a.

Looks like this commit has broken the linux builders.

Reverts #2457

This reverts commit e8fca9a.

Looks like this commit has broken the linux builders.
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer
Copy link
Contributor Author

@compnerd @shahmishal I am going to commit this revert to get the bots blue but do we need do fix the bots configurations to make this work?

@aschwaighofer aschwaighofer merged commit 72d266e into swiftlang:master Aug 26, 2019
@compnerd
Copy link
Member

@aschwaighofer - can you share any information on the failure? This went through the regular testing. The build-script is building a newer CMake at this point, so we should have the necessary CMake available.

@aschwaighofer
Copy link
Contributor Author

@compnerd
Copy link
Member

@shahmishal - could you verify if the 14.04 and 16.04 bots use build-script/update-checkout? It seems that they aren't. As it is, these bots are no longer capable of building master-next so perhaps it is time to either retire the 14.04 and 16.04 bots or start bootstrapping more tools there. (CC: @xiaobai)

@shahmishal
Copy link
Member

@compnerd This is failing because I need to update the Linux bots to start checking out CMake, we don't use update-checkout in regular job because we don't get change log. Jenkins only provides change log if we use Git plug-in.

I will update the jobs later today, and I cane merge this PR once it's updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants