Implement missing stringValue and descriptionWithLocale APIs #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -452,6 +456,12 @@ public class NSNumber : NSValue { | |||
| public func compare(otherNumber: NSNumber) -> NSComparisonResult { | |||
| return ._fromCF(CFNumberCompare(_cfObject, otherNumber._cfObject, nil)) | |||
| } | |||
|
|
|||
| public func descriptionWithLocale(locale: AnyObject?) -> String { | |||
| guard let aLocale = locale else { return description } | |||
There was a problem hiding this comment.
from a subclassing perspective, iirc this is a bit inverted - descriptionWithLocale should be the funnel point and description should call descriptionWithLocale(nil) but that is a minor 'nit since this is pretty reasonable as it stands.
phausler
added a commit
that referenced
this pull request
Mar 21, 2016
Implement missing stringValue and descriptionWithLocale APIs
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NSNumber reference documents the following two APIs which appear not to be implemented (even as calls to
NSUnimplemented):Additionally
stringValue()is described as a call todescriptionWithLocale(nil).I've therefore implemented
descriptionWithLocal(), andstringValue()as a call through to it.