[SR-789] Remove localization of NSNumber.description #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // let formatter = CFNumberFormatterCreate(nil, locale, kCFNumberFormatterNoStyle) | ||
| // CFNumberFormatterSetProperty(formatter, kCFNumberFormatterMaxFractionDigits, 15._bridgeToObject()) | ||
| // return CFNumberFormatterCreateStringWithNumber(nil, formatter, self._cfObject)._swiftObject | ||
| // } |
There was a problem hiding this comment.
probably can remove the commented out code. git history is a beautiful thing ;)
|
I will merge this and we can follow up on @phausler's suggestion. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Dup and redirect stdout to defend against accidental print()
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for SR-789 which reports that
NSNumber.descriptionis providing a localised string whereas it didn't do so previously.In order to be behaviour compatible I've made a slight modification to the existing implementation to use a number formatter style of
kCFNumberFormatterNoStylerather thankCFNumberFormatterDecimalStyle.At the same time I've done some refactoring to improve the delegation between
descriptionanddescriptionWithLocale()as suggested in PR #277 and added tests for bothdescriptionanddescriptionWithLocale()