Create a file with permissions that respects umask #2851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** `Data.write(to:)` is a only method in the Foundation that can create a regular file. However, it ignores `uamask` and always set 0600 permission unlike macOS Foundation, which respects process `umask`. **Solution** 1. With `.atomic` write option It uses `mkstemp(3)` in `_NSCreateTemporaryFile`, which is always creating a file with 0600 permission, if the system follows the latest POSIX specification or the permission is undefined. On macOS Foundation, therefore `_NSCreateTemporaryFile` uses `mktemp(3)` and `open(2)` instead to respect `umask`. 2. Without `.atomic` write option It uses `0o600` even if it uses `open(2)` that respects `umask`. Simply gives `0o666` instead. This is a bug caused by previous commit in swiftlang#1876. JIRA: https://bugs.swift.org/browse/SR-13307
|
Could you add a regression test that validates that a file is created with the correct permissions, thanks |
|
@swift-ci test |
|
@spevans Sure! the test need to change process’s |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Data.write(to:)is a only method in the Foundation that can create aregular file.
However, it ignores
umaskand always set 0600 permission unlikemacOS Foundation, which respects process
umask.Solution
With
.atomicwrite optionIt uses
mkstemp(3)in_NSCreateTemporaryFile, which is alwayscreating a file with 0600 permission, if the system follows
the latest POSIX specification or the permission is undefined.
On macOS Foundation, therefore
_NSCreateTemporaryFileusesmktemp(3)andopen(2)instead to respectumask.Without
.atomicwrite optionIt uses
0o600even if it usesopen(2)that respectsumask.Simply gives
0o666instead.This is a bug caused by previous commit in
#1876.
Swift JIRA is https://bugs.swift.org/browse/SR-13307.