Skip to content

Revert "Create a file with permissions that respects umask" #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

compnerd
Copy link
Member

Reverts #2851

This breaks on Windows

@compnerd
Copy link
Member Author

CC: @millenomi @valeriyvan

@compnerd
Copy link
Member Author

@swift-ci please test

@millenomi
Copy link
Contributor

I merge one patch, and.

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@millenomi
Copy link
Contributor

cc @niw.

@niw
Copy link
Contributor

niw commented Aug 21, 2020

Oh no..! It should be opaque for Windows.. Let me see again.
@compnerd Thank you for catching it.

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@compnerd compnerd merged commit 4caa33a into master Aug 21, 2020
@compnerd compnerd deleted the revert-2851-wip/fix_nsdata_ignores_umask branch August 21, 2020 14:49
@niw
Copy link
Contributor

niw commented Aug 25, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants