Implement basic initializers of NSAttributedString #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public class NSAttributedString : NSObject, NSCopying, NSMutableCopying, NSSecureCoding { | ||
|
|
||
| private var _cfAttributedString: CFAttributedString! |
There was a problem hiding this comment.
this would make NSAttributedString to be a has-a versus an is-a relationship to CFAttributedString; which is a variation (however it probably does not matter since there are not any CF apis that could take a attributed string.
It would be better to have this not be null resettable; removing the ! would be preferable.
|
@swift-ci Please test |
The implementation is based on CFAttributedString
`test_initWithAttributedString` was not included in TestNSAttributedString.allTests previously
These changes are following The Design Principles documentation: https://github.com/apple/swift-corelibs-foundation/blob/master/Docs/Design.md
|
@swift-ci please test |
|
Hm, looks like this caused a build failure on Ubuntu 14.04: |
|
I reverted the commit for now... |
|
@parkera I will look into that, thanks. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
add note about swift file recognition to vim-lsp section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented and tested the following methods (and properties):
public var string: Stringpublic var length: Intpublic init(string str: String)public init(string str: String, attributes attrs: [String : AnyObject]?)public init(attributedString attrStr: NSAttributedString)The implementation is based on CFAttributedString.