Basic implementations of NSAttributedString #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start implementing the NSAttributedString as is-a CFAttributedString, this commit contains some basic initializer implementations
eyeplum
changed the title
|
|
||
| public class NSAttributedString : NSObject, NSCopying, NSMutableCopying, NSSecureCoding { | ||
|
|
||
| private let _cfinfo = _CFInfo(typeID: CFAttributedStringGetTypeID()) | ||
| private let _string: NSString |
There was a problem hiding this comment.
I tried to use private let _string: String here, but encountered EXC_BAD_ACCESS at CFString function calls like CFStringGetLength ( inside the CF_SWIFT_FUNCDISPATCHV macro ).
I couldn't figure out why, but found out that with a NSString, everything seemed to be fine.
There was a problem hiding this comment.
Do you think https://bugs.swift.org/browse/SR-1129 could be related?
There was a problem hiding this comment.
SR-1129 looks like a compile time error, what I encountered is a runtime error.
So, maybe they are not related.
My guess is that this is a memory related issue.
|
Thanks! |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
…ang#334) * Replaces two logs since those don't result in response messages anymore * Adds a func for sending messages synchronously, to get the two messages out before fatalError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different from #297, this time I'm trying to implement the NSAttributedString to be a is-a relationship to CFAttributedString.