Skip to content

Implemented NSAffineTransform.init() with tests #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2015
Merged

Implemented NSAffineTransform.init() with tests #37

merged 1 commit into from
Dec 8, 2015

Conversation

mattrajca
Copy link
Contributor

As described in the reference for NSAffineTransform, this initializer:

Creates and returns a new NSAffineTransform object initialized to the identity matrix.

Part of this change:

  • an initializer for the underlying NSAffineTransformStruct's members has been implemented
  • an initializer for creating Doubles from CGFloats has been added to aid testing. Its signature is identical to the one in CoreGraphics in the iOS 9.1 SDK. Tests are implemented in terms of Doubles since XCTAssertEqualWithAccuracy only works with types that implement FloatingPointType, which CGFloat currently does not.

As described in the reference for NSAffineTransform, this initializer:

    Creates and returns a new NSAffineTransform object initialized to the identity matrix.
@mattrajca
Copy link
Contributor Author

The tests for this pass once swiftlang/swift-corelibs-xctest#7 is fixed.

@mattrajca
Copy link
Contributor Author

swiftlang/swift-corelibs-xctest#7 has been fixed and the tests now pass.

@parkera parkera merged commit 98862b4 into swiftlang:master Dec 8, 2015
parkera added a commit that referenced this pull request Dec 8, 2015
@parkera
Copy link
Contributor

parkera commented Dec 8, 2015

I had to fix up a couple of things (DBL_MAX not available on Linux, init should be @_transparent), but after that I merged it in.

atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
[lsp] Document all of the message types and split up into separate files
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Apr 29, 2021
…f6492e549da0fcc4b02c

Print a message if lit detects the swift benchmarks are usable for in…
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants