XCTAssertEqualWithAccuracy behavor does not match true XCTest.framework #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The accuracy threshold check only works with unsigned numbers, however the distanceTo method we get from Strideable works in terms of offsets which can be negative. We need to take the absolute value of the distance. This issue was causing tests for swiftlang/swift-corelibs-foundation#37 to fail.
parkera
added a commit
that referenced
this pull request
Dec 5, 2015
XCTAssertEqualWithAccuracy behavor does not match true XCTest.framework
|
Thanks! |
|
@parkera: As an aside, I find it really weird that |
|
@mattrajca This is great feedback for the discussion on Swift 3 naming conventions. Part of that effort is to audit the Swift standard library for names like this. I think swift-dev or swift-evolution would be a great place to discuss it. |
modocache
added a commit
to modocache/swift-corelibs-xctest
that referenced
this pull request
Jan 8, 2016
swiftlang#7 fix a problem with XCTAssertEqualsWithAccuracy. This test ensures that fix does not regress.
modocache
added a commit
to modocache/swift-corelibs-xctest
that referenced
this pull request
Jan 8, 2016
swiftlang#7 fixed a problem with XCTAssertEqualsWithAccuracy. This test ensures that fix does not regress.
modocache
added a commit
to modocache/swift-corelibs-xctest
that referenced
this pull request
Jan 11, 2016
swiftlang#7 fixed a problem with XCTAssertEqualsWithAccuracy. This test ensures that fix does not regress.
modocache
added a commit
to modocache/swift-corelibs-xctest
that referenced
this pull request
Jan 13, 2016
swiftlang#7 fixed a problem with XCTAssertEqualsWithAccuracy. This test ensures that fix does not regress.
mike-ferris
pushed a commit
that referenced
this pull request
Jan 13, 2016
…withaccuracy [Tests] Add regression tests for pull request #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accuracy threshold check only works with unsigned numbers, however the
distanceTomethod we get fromStrideableworks in terms of offsets which can be negative. We need to take the absolute value of the distance.This issue is causing tests for swiftlang/swift-corelibs-foundation#37 to fail.