UnsafePointer conversion fixes. #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parkera This is just a stop-gap to allow the build to succeed when we're ready to pull in the stdlib changes sometime today. I plan to go through over all these changes again later and find a cleaner way to handle things. |
|
I'll update this after Also, I noticed a stdlib dependency which hasn't been checked in yet, so this should not be merged. |
atrick
changed the title
|
Ok. |
atrick
force-pushed
the
rawptr
branch
2 times, most recently
from
e0a6c0c to
9d77896
Compare
Update for SE-0107: UnsafeRawPointer. Some of this is pretty rough, but it's necessary to keep the build working and land the raw vs. typed pointer feature. As expected there are two major pain points: 1. CString vs. UTF8 types 2. NSData and company use pointer to UInt8 for untyped memory.
|
This passes 'build-script -R --llbuild --foundation --xctest -T' with the latest swift master. |
atrick
changed the title
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for SE-0107: UnsafeRawPointer.
Some of this is pretty rough, but it's necessary to
keep the build working and land the raw vs. typed pointer feature.
As expected there are two major pain points: