[SR-1988] Ranges of String.UTF16View.Index have negative count #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveLiu888
force-pushed
the
SR-1988-UTF16View-Range-Neg-Count
branch
from
8d1c13f to
c5f89b8
Compare
|
Was this a regression introduced by If we need to change this then it should be in both the overlay code in Swift as well as swift-corelibs-foundation. |
|
Thanks for the heads up, pull submitted here swiftlang/swift#4072. |
DaveLiu888
force-pushed
the
SR-1988-UTF16View-Range-Neg-Count
branch
from
c5f89b8 to
9efd4be
Compare
DaveLiu888
force-pushed
the
SR-1988-UTF16View-Range-Neg-Count
branch
from
9efd4be to
c519e4b
Compare
|
update: |
DaveLiu888
force-pushed
the
SR-1988-UTF16View-Range-Neg-Count
branch
from
6420b98 to
2eeb88c
Compare
|
@parkera The associated swiftlang/swift#4073 pull has been merged. |
|
Looks good. Thanks for finding this! |
|
@parkera any time, learning a ton in the processes 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Ranges of String.UTF16View.Index have negative count
Resolving bug number: 1988 (https://bugs.swift.org/browse/SR-1988)