fix neg count SR-1988 #4072
Closed
fix neg count SR-1988 #4072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveLiu888
force-pushed
the
SR-1988-UTF16View-Range-Neg-Count-stdlib
branch
from
92de3e4 to
7c3bd36
Compare
|
@swift-ci Please test |
|
@DaveLiu888 Could you review #4073? It has more thorough tests. |
|
The tests don't pass in this PR. Closing in favor of #4073. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Ranges of String.UTF16View.Index have negative count
Resolved bug number: 1988 (https://bugs.swift.org/browse/SR-1988))
swift-corelibs-foundation pull swiftlang/swift-corelibs-foundation#505