[Feedback] Initial NSByteCountFormatter implementation #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* Convenience method on stringForObjectValue:. Convert a byte count into a string without creating an NSNumber. | ||
| */ | ||
| public func stringFromByteCount(byteCount: Int64) -> String { NSUnimplemented() } | ||
|
|
||
| /* Specify the units that can be used in the output. If NSByteCountFormatterUseDefault, uses platform-appropriate settings; otherwise will only use the specified units. This is the default value. Note that ZB and YB cannot be covered by the range of possible values, but you can still choose to use these units to get fractional display ("0.0035 ZB" for instance). | ||
| */ | ||
| public var allowedUnits: NSByteCountFormatterUnits | ||
| internal var _allowedUnits: NSByteCountFormatterUnits = .UseDefault |
There was a problem hiding this comment.
technically this pattern is not needed and you could write it as the simpler version like:
public var allowedUnits: NSByteCountFormatterUnits = .UseDefault
|
The default values look correct to me. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[swiftpm] Update to latest master
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used NSDateFormatter and some other classes as a reference point. Shall I continue with the implementation?