Implementation of NSByteCountFormatter default values #80
Conversation
| public class func stringFromByteCount(byteCount: Int64, countStyle: NSByteCountFormatterCountStyle) -> String { NSUnimplemented() } | ||
|
|
||
| public class func stringFromByteCount(byteCount: Int64, countStyle: NSByteCountFormatterCountStyle) -> String { | ||
| let byteCountFormatter = NSByteCountFormatter() |
There was a problem hiding this comment.
contradicts the docs, which say without creating an NSByteCountFormatter
There was a problem hiding this comment.
From my understating this is a convenience method, when you are getting a result without manual creation of the NSByteCountFormatter, however this method suppose to use the NSByteCountFormatter logic in order to create a formatted string.
The Foundation documentation is saying "Converts a byte count into the specified string format without creating an NSNumber object." https://developer.apple.com/library/prerelease/ios/documentation/Foundation/Reference/NSByteCountFormatter_Class/index.html#//apple_ref/occ/clm/NSByteCountFormatter/stringFromByteCount:countStyle:
There was a problem hiding this comment.
then the docs here need to be updated. I'd also be tempted to disassemble foundation and see if it's using a cached singleton there
There was a problem hiding this comment.
It just calls into a private function which is shared with the formatter object.
[swiftpm] Update to latest master
[test] Disable failing check in test-sourcekit-lsp
[pull] swiftwasm from master
Default values are added.
Unit test for the NSByteCountFormatter added.
Based on comments from the closed pull request #61