-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implementation of NSByteCountFormatter default values #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2015 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See http://swift.org/LICENSE.txt for license information | ||
| // See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
|
|
||
|
|
||
|
|
||
| #if DEPLOYMENT_RUNTIME_OBJC || os(Linux) | ||
| import Foundation | ||
| import XCTest | ||
| #else | ||
| import SwiftFoundation | ||
| import SwiftXCTest | ||
| #endif | ||
|
|
||
|
|
||
|
|
||
| class TestNSByteCountFormatter : XCTestCase { | ||
|
|
||
| var allTests : [(String, () -> ())] { | ||
| return [ | ||
| ("test_DefaultValues", test_DefaultValues) | ||
| ] | ||
| } | ||
|
|
||
| func test_DefaultValues() { | ||
| let formatter = NSByteCountFormatter() | ||
| XCTAssertEqual(formatter.allowedUnits, NSByteCountFormatterUnits.UseDefault) | ||
| XCTAssertEqual(formatter.countStyle, NSByteCountFormatterCountStyle.File) | ||
| XCTAssertEqual(formatter.allowsNonnumericFormatting, true) | ||
| XCTAssertEqual(formatter.includesUnit, true) | ||
| XCTAssertEqual(formatter.includesCount, true) | ||
| XCTAssertEqual(formatter.includesActualByteCount, false) | ||
| XCTAssertEqual(formatter.adaptive, true) | ||
| XCTAssertEqual(formatter.zeroPadsFractionDigits, false) | ||
| XCTAssertEqual(formatter.formattingContext, NSFormattingContext.Unknown) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,4 +38,5 @@ XCTMain([ | |
| TestNSXMLParser(), | ||
| TestNSDate(), | ||
| TestNSTimeZone(), | ||
| TestNSByteCountFormatter(), | ||
| ]) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contradicts the docs, which say
without creating an NSByteCountFormatterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understating this is a convenience method, when you are getting a result without manual creation of the NSByteCountFormatter, however this method suppose to use the NSByteCountFormatter logic in order to create a formatted string.
The Foundation documentation is saying "Converts a byte count into the specified string format without creating an NSNumber object." https://developer.apple.com/library/prerelease/ios/documentation/Foundation/Reference/NSByteCountFormatter_Class/index.html#//apple_ref/occ/clm/NSByteCountFormatter/stringFromByteCount:countStyle:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then the docs here need to be updated. I'd also be tempted to disassemble foundation and see if it's using a cached singleton there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just calls into a private function which is shared with the formatter object.