NSUUID improvements #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (bytes != nil) { | ||
| memcpy(unsafeBitCast(buffer, UnsafeMutablePointer<Void>.self), UnsafePointer<Void>(bytes), 16) | ||
| } else { | ||
| memset(unsafeBitCast(buffer, UnsafeMutablePointer<Void>.self), 0, 16) |
There was a problem hiding this comment.
actually the darwin implementation crashes when nil is passed so perhaps a precondition assertion would be more correct
|
overall this looks good, the behavior of the nil initializer is a bit undefined on darwin so that is just a minor issue if any; once conflicts are resolved by a rebase this looks good to go to me |
|
I rebased and resolved conflicts. I did not change the check against nil, so the |
0xced
force-pushed
the
NSUUID
branch
2 times, most recently
from
7001407 to
5bed24a
Compare
|
Thanks! |
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEqualandhashNSUUID(UUIDBytes: nil)UUIDStringimplementationdescription