-
Notifications
You must be signed in to change notification settings - Fork 1.2k
NSUUID improvements #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8fcc10d
Add an empty test case for NSUUID
0xced 052fd10
Add test for NSUUID equality
0xced 98c5760
Add test for invalid UUID
0xced 1c3eac7
Add test for initializing NSUUID with nil
0xced ed618f9
Add test for NSUUID.UUIDString
0xced 3b3d540
Add test for NSUUID.description
0xced 1d874d7
Add (disabled) test for NSUUID NSCoding
0xced File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2014 - 2015 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See http://swift.org/LICENSE.txt for license information | ||
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
|
||
|
||
#if DEPLOYMENT_RUNTIME_OBJC || os(Linux) | ||
import Foundation | ||
import XCTest | ||
#else | ||
import SwiftFoundation | ||
import SwiftXCTest | ||
#endif | ||
|
||
|
||
class TestNSUUID : XCTestCase { | ||
|
||
var allTests : [(String, () -> ())] { | ||
return [ | ||
("test_Equality", test_Equality), | ||
("test_InvalidUUID", test_InvalidUUID), | ||
("test_InitializationWithNil", test_InitializationWithNil), | ||
("test_UUIDString", test_UUIDString), | ||
("test_description", test_description), | ||
// Disabled until NSKeyedArchiver and NSKeyedUnarchiver are implemented | ||
// ("test_NSCoding", test_NSCoding), | ||
] | ||
} | ||
|
||
func test_Equality() { | ||
let uuidA = NSUUID(UUIDString: "E621E1F8-C36C-495A-93FC-0C247A3E6E5F") | ||
let uuidB = NSUUID(UUIDString: "e621e1f8-c36c-495a-93fc-0c247a3e6e5f") | ||
let uuidC = NSUUID(UUIDBytes: [0xe6,0x21,0xe1,0xf8,0xc3,0x6c,0x49,0x5a,0x93,0xfc,0x0c,0x24,0x7a,0x3e,0x6e,0x5f]) | ||
let uuidD = NSUUID() | ||
|
||
XCTAssertEqual(uuidA, uuidB, "String case must not matter.") | ||
XCTAssertEqual(uuidA, uuidC, "A UUID initialized with a string must be equal to the same UUID initialized with its UnsafePointer<UInt8> equivalent representation.") | ||
XCTAssertNotEqual(uuidC, uuidD, "Two different UUIDs must not be equal.") | ||
} | ||
|
||
func test_InvalidUUID() { | ||
let uuid = NSUUID(UUIDString: "Invalid UUID") | ||
XCTAssertNil(uuid, "The convenience initializer `init?(UUIDString string:)` must return nil for an invalid UUID string.") | ||
} | ||
|
||
func test_InitializationWithNil() { | ||
let uuid = NSUUID(UUIDBytes: nil) | ||
XCTAssertEqual(uuid, NSUUID(UUIDBytes: [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]), "The convenience initializer `init(UUIDBytes bytes:)` must return the Nil UUID when UUIDBytes is nil.") | ||
} | ||
|
||
func test_UUIDString() { | ||
let uuid = NSUUID(UUIDBytes: [0xe6,0x21,0xe1,0xf8,0xc3,0x6c,0x49,0x5a,0x93,0xfc,0x0c,0x24,0x7a,0x3e,0x6e,0x5f]) | ||
XCTAssertEqual(uuid.UUIDString, "e621e1f8-c36c-495a-93fc-0c247a3e6e5f", "The UUIDString representation must be lowercase as defined by RFC 4122.") | ||
} | ||
|
||
func test_description() { | ||
let uuid = NSUUID() | ||
XCTAssertEqual(uuid.description, uuid.UUIDString, "The description must be the same as the UUIDString.") | ||
} | ||
|
||
func test_NSCoding() { | ||
let uuidA = NSUUID() | ||
let uuidB = NSKeyedUnarchiver.unarchiveObjectWithData(NSKeyedArchiver.archivedDataWithRootObject(uuidA)) as! NSUUID | ||
XCTAssertEqual(uuidA, uuidB, "Archived then unarchived uuid must be equal.") | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,5 +42,6 @@ XCTMain([ | |
TestNSScanner(), | ||
TestNSHTTPCookie(), | ||
TestNSGeometry(), | ||
TestNSUUID(), | ||
]) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually the darwin implementation crashes when nil is passed so perhaps a precondition assertion would be more correct