if building Swift overlay, install into Swift toolchain dir structure #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the build/install logic for the Swift overlay portion of libdispatch to assume that if the Swift overlay is being built then the intended install target is a Swift toolchain. In conjunction with the change to swift/utils/build-script-impl in PR#1212, this change enables Swift programs compiled using the resulting built toolchain to successfully import Dispatch with only -Xcc -fblocks as extra arguments to swiftc (no longer need to also specify -I<path-to-dispatch-module>).
MadCoder
added a commit
that referenced
this pull request
Feb 15, 2016
if building Swift overlay, install into Swift toolchain dir structure
das
pushed a commit
that referenced
this pull request
Jun 14, 2016
if building Swift overlay, install into Swift toolchain dir structure Signed-off-by: Daniel A. Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the build/install logic for the Swift overlay portion of
libdispatch to assume that if the Swift overlay is being built
then the intended install target is a Swift toolchain.
In conjunction with the change to swift/utils/build-script-impl
in swiftlang/swift#1212, this change enables Swift programs compiled using
the resulting built toolchain to successfully import
Dispatch with only -Xcc -fblocks as extra arguments to swiftc
(no longer need to also specify -I).