Next step in connecting libdispatch and foundation builds #1212
Conversation
| @@ -1828,7 +1835,7 @@ for deployment_target in "${HOST_TARGET}" "${CROSS_TOOLS_DEPLOYMENT_TARGETS[@]}" | |||
| autoreconf -fvi | |||
| popd | |||
| pushd "${LIBDISPATCH_BUILD_DIR}" | |||
| "${LIBDISPATCH_SOURCE_DIR}"/configure --prefix="${INSTALL_DESTDIR}"/"${INSTALL_PREFIX}" | |||
| "${LIBDISPATCH_SOURCE_DIR}"/configure --prefix="${INSTALL_DESTDIR}"/"${INSTALL_PREFIX}" --with-swift-sdk="${SWIFT_BUILD_PATH}" | |||
There was a problem hiding this comment.
"SDK" seems to be the wrong way to call the build directory. It is usually called the "toolchain". The SDK is the directory with the headers and frameworks.
There was a problem hiding this comment.
ok. thanks. I didn't know that. I'll make the change here and in the corresponding pull request to libdispatch.
|
LGTM modulo the SDK comment. |
Three small changes for building libdispatch and foundation together. (1) Put libdispatch into PRODUCTS before foundation (2) Pass path to swift down into libdispatch build (3) Pass paths to libdispatch down into foundation build
|
changed to --with-swift-toolchain & squashed |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Awesome work, @dgrove-oss. Very excited to see this happen. On a related note, I'm expecting to make a similar change soon that establishes a dependency between XCTest and Foundation. The pull request that will introduce the dependency is swiftlang/swift-corelibs-xctest#43, the corresponding change to the build script is modocache@a17c05b. Just a heads up! |
|
LGTM. I'm currently cherry-picking this commit into my binaries. This is amazing, SO excited to have dispatch on Linux. |
|
@gribozavr. Hi, just pinging to see if this could be merged. Looks like CI tests passed. Thanks! |
Next step in connecting libdispatch and foundation builds
|
@dgrove-oss Sorry for the delay! |
Three small changes for building libdispatch and foundation together.
(1) Put libdispatch into PRODUCTS before foundation
(2) Pass path to swift down into libdispatch build
(3) Pass paths to libdispatch down into foundation build