io: fix dispatch_io_create_with_path() on Windows #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Jun 11, 2019
|
Addressed review comments. cc @compnerd |
|
@swift-ci please test |
ktopley-apple
suggested changes
Jun 21, 2019
src/io.c
Outdated
| // Check parent directory | ||
| char *c = strrchr(path_data->path, '/'); | ||
| char *c = NULL; | ||
| for (size_t i = path_data->pathlen; i-- > 0;) { |
There was a problem hiding this comment.
Although this code is correct, I found it confusing at first because it appears that the start index should be path_data->pathlen - 1, but this is not the case because i-- decrements before each pass of the loop. I understand the reason for the - size_t is unsigned. Maybe it would be clearer to cast to ssize_t:
for (ssize_t i = (ssize_t)path_data->pathlen - 1; i >= 0; i--)
There was a problem hiding this comment.
I forgot that Dispatch declares ssize_t on Windows. (It normally isn't present.) That sounds better, thanks!
This function assumes POSIX-style paths. Add Windows-specific checks for absolute paths and separators. Additionally, `_dispatch_fd_entry_guarded_open()` does not handle the open flags correctly. `O_RDONLY` is 0, so we need to use a switch statement to check for it. `O_EXCL` is not handled at all. `O_TRUNC`'s behavior needs to change depending on whether `O_CREAT` is specified. Finally, we must open files with maximum sharing to match the semantics of other platforms. (The dispatch_io test already has a handle open when it calls `dispatch_io_create_with_path()`.)
ktopley-apple
approved these changes
Jun 26, 2019
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
io: fix dispatch_io_create_with_path() on Windows Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function assumes POSIX-style paths. Add Windows-specific checks for
absolute paths and separators.
Additionally,
_dispatch_fd_entry_guarded_open()does not handle theopen flags correctly.
O_RDONLYis 0, so we need to use a switchstatement to check for it.
O_EXCLis not handled at all.O_TRUNC'sbehavior needs to change depending on whether
O_CREATis specified.Finally, we must open files with maximum sharing to match the semantics
of other platforms. (The dispatch_io test already has a handle open when
it calls
dispatch_io_create_with_path().)