tests: port dispatch_io and dispatch_io_pipe_close to Windows #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Jun 12, 2019
tests/dispatch_io.c
Outdated
| @@ -241,23 +245,30 @@ static void | |||
| test_io_read_write(void) | |||
| { | |||
| char *path_in = dispatch_test_get_large_file(); | |||
| #if defined(_WIN32) | |||
| char *temp_dir = getenv("TMP") ?: getenv("TEMP"); | |||
There was a problem hiding this comment.
I think it would be nicer to avoid the GNU extension here:
char *temp_dir = getenv("TMP");
if (temp_dir == NULL)
temp_dir = getenv("TEMP");
This lets us build and run the full extended test suite for Windows! I caught several bugs in Dispatch's Windows port while I was working on this and I submitted pull requests to fix them (#493, #494). The only dispatch_io test case which fails right now is test_io_stop, and that's because we don't have pipe support on Windows yet.
compnerd
approved these changes
Jun 27, 2019
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
tests: port dispatch_io and dispatch_io_pipe_close to Windows Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us build and run the full extended test suite for Windows! I
caught several bugs in Dispatch's Windows port while I was working on
this and I submitted pull requests to fix them (#493, #494). The only
dispatch_io test case which fails right now is test_io_stop, and that's
because we don't have pipe support on Windows yet.