Address TODO to unblock master-next. #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested changes
Jul 16, 2019
| PRIVATE | ||
| -fblocks | ||
| -momit-leaf-frame-pointer) | ||
| check_c_compiler_flag("-momit-leaf-frame-pointer -Werror -Wall -O3" C_SUPPORTS_OMIT_LEAF_FRAME_POINTER) |
There was a problem hiding this comment.
-Werror -Wall -O3 is not required when using check_c_compiler_flag. See the documentation at https://cmake.org/cmake/help/latest/module/CheckCCompilerFlag.html.
I think that we should just do two target_compile_options calls here.
check_c_compile_flag("-momit-leaf-frame-pointer" CC_SUPPORTS_MOMIT_LEAF_FRAME_POINTER)
target_compile_options(dispatch PRIVATE -fblocks)
if(CC_SUPPORTS_MOMIT_LEAF_FRAME_POINTER)
target_compile_options(dispatch PRIVATE -momit-leaf-frame-pointer)
endif()
There was a problem hiding this comment.
check_c_compiler_flag just runs the compilation command with the provided flag. Unfortunately, clang will only complain with this combination of flags.
compnerd
approved these changes
Jul 16, 2019
|
@pschuh - thanks for this patch and for the quick turn-around on the review! |
|
@swift-ci please test Linux platform |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Address TODO to unblock master-next. Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, this is a build that fails: https://ci.swift.org/view/swift-master-next/job/oss-swift-incremental-RA-linux-ubuntu-16_04-master-next/11406/console
It repeatedly complains about "-momit-leaf-frame-pointer" being unused.