-
Notifications
You must be signed in to change notification settings - Fork 10.5k
build: explicitly specify the python path #26169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: explicitly specify the python path #26169
Conversation
@swift-ci please smoke test |
CC: @shahmishal @jrose-apple @gottesmm Okay, this should "repair" the CI builds for master-next. It explicitly sets the python to python 2.7 to ensure that we get the right python version so that we can build. |
@compnerd Thanks! |
Please test with following PRs: @swift-ci please test |
Build failed |
92d10a0
to
2c2cbb0
Compare
Please test with following PRs: @swift-ci please test |
Build failed |
Build failed |
2c2cbb0
to
d5c4606
Compare
@swift-ci please test |
Build failed |
Build failed |
d5c4606
to
97e7234
Compare
Okay, the Linux side is good now - there are 3 swift test failures, but thats a separate issue.
|
@swift-ci please test |
Build failed |
Build failed |
This ensures that we use python 2.7 when building LLVM. The LLVM tooling has not yet been ported to python 3, and this breaks the CI builds which are now finding python 3 via `PATH`.
97e7234
to
2d8cf9d
Compare
@swift-ci please test |
Build failed |
Build failed |
Okay, this is ready to go in now. The Linux failure is the test failures:
The Darwin build is failing due to the lldb install rules:
However, this fixes the Python on both, which gets us further along the path of getting master-next fixed. |
This ensures that we use python 2.7 when building LLVM. The LLVM
tooling has not yet been ported to python 3, and this breaks the CI
builds which are now finding python 3 via
PATH
.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.