Skip to content

add a linker search path to account for changes in library paths on platforms without fat binaries #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

lanza
Copy link
Contributor

@lanza lanza commented Feb 26, 2018

swiftlang/swift#14243 modifies the paths for built libraries to oldpath/arch/libXYZ. This change adds a search path to account for this.

Requires
swiftlang/swift#14243
swiftlang/swift#14835

@lanza
Copy link
Contributor Author

lanza commented Feb 26, 2018

@compnerd

@compnerd
Copy link
Member

This was tested at swiftlang/swift#14835

@compnerd compnerd merged commit 01e6126 into swiftlang:master Feb 28, 2018
@huonw
Copy link

huonw commented Feb 28, 2018

Unfortunately it looks like this breaks testing: https://ci.swift.org/job/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/289/console

...
22:46:46 + popd
22:46:46 ~/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10
22:46:46 xctest: using gold linker
22:46:46 + /home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/swift-corelibs-xctest/build_script.py --swiftc=/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/buildbot_incremental/swift-linux-x86_64/bin/swiftc --build-dir=/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/buildbot_incremental/xctest-linux-x86_64 --foundation-build-dir=/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/buildbot_incremental/foundation-linux-x86_64/Foundation --libdispatch-src-dir=/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/swift-corelibs-libdispatch --libdispatch-build-dir=/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/buildbot_incremental/libdispatch-linux-x86_64 --release
22:46:46 Traceback (most recent call last):
22:46:46   File "/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/swift-corelibs-xctest/build_script.py", line 577, in <module>
22:46:46     main()
22:46:46   File "/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/swift-corelibs-xctest/build_script.py", line 573, in main
22:46:46     parsed_args.func(parsed_args)
22:46:46   File "/home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/swift-corelibs-xctest/build_script.py", line 159, in build
22:46:46     swift_build_dir = os.path.abspath(args.swift_build_dir)
22:46:46   File "/usr/lib/python2.7/posixpath.py", line 360, in abspath
22:46:46     if not isabs(path):
22:46:46   File "/usr/lib/python2.7/posixpath.py", line 54, in isabs
22:46:46     return s.startswith('/')
22:46:46 AttributeError: 'NoneType' object has no attribute 'startswith'
22:46:46 /home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
22:46:46 /home/buildnode/jenkins/workspace/oss-swift-5.0-incremental-RA-linux-ubuntu-16_10/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
...

It'd be great to get this fixed as soon as possible. Thanks!

@lanza
Copy link
Contributor Author

lanza commented Feb 28, 2018

Hey @huonw. This PR depends upon swiftlang/swift#14835 and will run just fine alongside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants