Skip to content

build: depend on the architecture variant on non-MachO #14243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

For the non-MachO targets, which do not have the concept of fat
binaries, depend explicitly on the architecture variant. This is
particularly useful for Windows which permits cross-compilation and
cross-targeting of all the variants even though it does not support fat
binaries. This allows us to build a single variant of the windows
standard library at a time in the case that we would like to build a
subset of the targets.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 825864411b7712db40323ff6332444400fb6167d

@jrose-apple
Copy link
Contributor

Please be consistent with #13108 about whether this is testing for Mach-O or IS_DARWIN.

@compnerd
Copy link
Member Author

@jrose-apple I thought we settled on it being a MachO thing, not a Darwin thing.

@jrose-apple
Copy link
Contributor

I saw you comment that but I didn't see if @zbowling agreed, and I don't think anyone else has been following it.

For the non-MachO targets, which do not have the concept of fat
binaries, depend explicitly on the architecture variant.  This is
particularly useful for Windows which permits cross-compilation and
cross-targeting of all the variants even though it does not support fat
binaries.  This allows us to build a single variant of the windows
standard library at a time in the case that we would like to build a
subset of the targets.
@compnerd
Copy link
Member Author

compnerd commented Feb 3, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 825864411b7712db40323ff6332444400fb6167d

@swift-ci
Copy link
Contributor

swift-ci commented Feb 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 825864411b7712db40323ff6332444400fb6167d

@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2018

@swift-ci please test linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Feb 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - 5312266

@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2018

Please test with following pull request:
swiftlang/swift-corelibs-foundation#1354

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Feb 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - 5312266

@compnerd
Copy link
Member Author

Please test with following pull request:

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5312266

@compnerd compnerd closed this Mar 23, 2019
@compnerd compnerd deleted the skinny-variants branch March 23, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants