Use <caption> for table captions instead of <figcaption> #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables with captions will no longer be embedded in a <figure> with a <figcaption>. Instead, the <table> will simply have a <caption> as its first element when needed. For table captions, the position of the caption must be done in CSS since the <caption> is always required to be the first element of the <table> and cannot be moved to the end like they can with figure captions.
3 tasks
marinaaisa
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Thanks Marcus for reviewing #692 and submitting this new PR!
Since caption element has to be the first element of the table, this makes much more sense!
I reflected on the centered prop and I proposed a refactor in the CSS. Let me know if it makes sense or I'm missing some use case. (Hopefully not!)
Co-authored-by: Marina Aísa <[email protected]>
* replace `centered` prop with `position` * simplify margin styling
dobromir-hristov
approved these changes
Jul 3, 2023
|
@swift-ci test |
mportiz08
added a commit
to mportiz08/swift-docc-render
that referenced
this pull request
Jul 3, 2023
Use <caption> for tables instead of <figcaption>. Tables with captions will no longer be embedded in a <figure> with a <figcaption>. Instead, the <table> will simply have a <caption> as its first element when needed. Co-authored-by: Marina Aísa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 30234820
Summary
Use
<caption>for tables instead of<figcaption>.Tables with captions will no longer be embedded in a
<figure>with a<figcaption>. Instead, the<table>will simply have a<caption>as its first element when needed.For table captions, the position of the caption must be done in CSS since the
<caption>is always required to be the first element of the<table>and cannot be moved to the end like they can with figure captions.Testing
Steps:
<table><caption>instead of<figure><figcaption><table>Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded