Skip to content

[5.9] Use <caption> for table captions instead of <figcaption> #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

[5.9] Use <caption> for table captions instead of <figcaption> #707

merged 1 commit into from
Jul 6, 2023

Conversation

mportiz08
Copy link
Contributor

  • Explanation: Changes the HTML markup used for table captions
  • Scope: Impacts any pages with captioned tables
  • Issue: rdar://30234820
  • Risk: Medium, refactors the JS/HTML/CSS related to captions
  • Testing: Updated/added unit tests, verified that the <table><caption> markup is now used for table captions and that there are no regressions with the <figure><figcaption> markup used for code listing/image/video captions
  • Reviewer: @marinaaisa and @dobromir-hristov
  • Original PR: Use <caption> for table captions instead of <figcaption> #706

@mportiz08 @marinaaisa
Use <caption> for table captions instead of <figcaption> (swiftlang#706)
3f3e88d 
Use <caption> for tables instead of <figcaption>.

Tables with captions will no longer be embedded in a <figure> with a
<figcaption>. Instead, the <table> will simply have a <caption> as its
first element when needed.

Co-authored-by: Marina Aísa <[email protected]>
@mportiz08 mportiz08 requested a review from franklinsch July 3, 2023 17:13
@mportiz08
Copy link
Contributor Author

@swift-ci test

@dobromir-hristov dobromir-hristov merged commit 344160e into swiftlang:release/5.9 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mportiz08 @franklinsch @dobromir-hristov