Skip to content

Add support for the new -index-ignore-clang-modules flag #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

DavidGoldman
Copy link
Contributor

This flag was recently added in swiftlang/swift#58932.

@artemcm
Copy link
Contributor

artemcm commented Jun 3, 2022

Could you please update the Options according to the procedure in:
https://github.com/apple/swift-driver#rebuilding-optionsswift ?

It's okay if that also brings in some unrelated changes.

@artemcm
Copy link
Contributor

artemcm commented Jun 3, 2022

@swift-ci please test

@DavidGoldman
Copy link
Contributor Author

Looks like the failures are related to the cxx flag changes?

@artemcm
Copy link
Contributor

artemcm commented Jun 3, 2022

Looks like the failures are related to the cxx flag changes?

Gah, okay, feel free to un-do the Options.swift additions/removals unrelated to your change.

@DavidGoldman DavidGoldman force-pushed the ignoreclangmodulesflag branch from 690de78 to a3218a0 Compare June 3, 2022 21:00
@DavidGoldman
Copy link
Contributor Author

Can you trigger CI again? Thanks

@artemcm
Copy link
Contributor

artemcm commented Jun 3, 2022

@swift-ci please test

@DavidGoldman
Copy link
Contributor Author

Looks like the failures are related to the cxx flag changes?

Gah, okay, feel free to un-do the Options.swift additions/removals unrelated to your change.

Yep looks like that fixed it

@artemcm artemcm merged commit ff9682e into swiftlang:main Jun 3, 2022
@DavidGoldman DavidGoldman deleted the ignoreclangmodulesflag branch June 3, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants