Add -index-ignore-clang-modules flag to prevent indexing Clang modules
#58932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidGoldman
commented
May 16, 2022
DavidGoldman
commented
May 17, 2022
This flag avoids indexing import clang modules (pcms), behaving similar to `-index-ignore-system-modules` except for PCMs.
DavidGoldman
force-pushed
the
ignoreclangmoduleindexing
branch
from
aa8da95 to
65062c9
Compare
|
@swift-ci please test |
bnbarham
reviewed
May 27, 2022
DavidGoldman
added a commit
to DavidGoldman/llvm-project
that referenced
this pull request
May 31, 2022
This is the clang equivalent of swiftlang/swift#58932, to be used when building explicit clang modules for Swift to prevent repeated indexing of the same Clang PCM during remote builds. With this, the build system can index the Clang PCM when it is created and there's no need to ever index it again.
DavidGoldman
added a commit
to DavidGoldman/llvm-project
that referenced
this pull request
May 31, 2022
This is the clang equivalent of swiftlang/swift#58932, to be used when building explicit clang modules for Swift to prevent repeated indexing of the same Clang PCM during remote builds. With this, the build system can index the Clang PCM when it is created and there's no need to ever index it again.
|
@swift-ci please test |
DavidGoldman
added a commit
to DavidGoldman/llvm-project
that referenced
this pull request
Jun 2, 2022
This is the clang equivalent of swiftlang/swift#58932, to be used when building explicit clang modules for Swift to prevent repeated indexing of the same Clang PCM during remote builds. With this, the build system can index the Clang PCM when it is created and there's no need to ever index it again. (cherry picked from commit 2a822a6)
DavidGoldman
added a commit
to DavidGoldman/llvm-project
that referenced
this pull request
Jun 2, 2022
This is the clang equivalent of swiftlang/swift#58932, to be used when building explicit clang modules for Swift to prevent repeated indexing of the same Clang PCM during remote builds. With this, the build system can index the Clang PCM when it is created and there's no need to ever index it again. (cherry picked from commit 2a822a6)
bnbarham
approved these changes
Jun 2, 2022
This was referenced Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag avoids indexing imported clang modules (PCMs), similar to the
-index-ignore-system-modulesexcept it applies to the Clang PCMs.This flag is useful to avoid repeated indexing of the same Clang PCM during remote builds - useful with explicit module (PCMs) builds that execute remotely, where the build system will index the PCM once during its generation and there's no need to ever index it again.