Skip to content

[Explicit Modules] Pass '-explicit-interface-module-build' to interface build jobs. #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Aug 16, 2022

Companion change to swiftlang/swift#60556.

This allows us to gather all the required flags for compilation of a given interface during the dependency scan, and then use those flags directly during the build, instead of once again reading out flags from the interface file and instantiating a new compiler subInstance when building said interface.

@artemcm
Copy link
Contributor Author

artemcm commented Aug 16, 2022

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Aug 17, 2022

Cross-repo tests are looking green.

@artemcm artemcm requested review from nkcsgexi, xymus and tshortli August 17, 2022 16:38
@artemcm artemcm merged commit 1f2f5e9 into swiftlang:main Aug 17, 2022
@artemcm artemcm deleted the ExplicitInterfaceBuild branch August 17, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants