Skip to content

Add --enable-asan option in swift-driver #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

wrotki
Copy link
Contributor

@wrotki wrotki commented Mar 10, 2023

This is to support building the swift-driver with -sanitize=address when the Swift build preset specifies enable-asan. Without this option and with enable-asan in picture the entire Swift build fails due to ASAN initialization failure in swift-driver.

rdar://104661463

This is to support building the swift-driver with -sanitize=address
when the Swift build preset specifies enable-asan.
Without this option and with enable-asan in picture the entire Swift build
fails due to ASAN initialization failure in swift-driver.

rdar://104661463
@wrotki wrotki requested a review from artemcm March 10, 2023 17:18
@wrotki
Copy link
Contributor Author

wrotki commented Mar 10, 2023

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@artemcm
Copy link
Contributor

artemcm commented Mar 10, 2023

Just a note that this CI does not exercise the CMake build. So the actual testing once this gets enabled will need to be done from the main swift repo using cross-repository CI testing. 👍🏼

wrotki pushed a commit to swiftlang/swift that referenced this pull request Mar 10, 2023
This is to support building the swift-driver with -sanitize=address when the Swift build preset specifies enable-asan. Without this option and with enable-asan in picture the entire Swift build fails due to ASAN initialization failure in swift-driver.
This commit is dependent on swiftlang/swift-driver#1310 being merged first

rdar://104661463
@wrotki
Copy link
Contributor Author

wrotki commented Mar 10, 2023

@swift-ci please smoke test

@artemcm
Copy link
Contributor

artemcm commented Mar 10, 2023

@swift-ci please test

@artemcm
Copy link
Contributor

artemcm commented Mar 10, 2023

@swift-ci please smoke test

There is no smoke test on this repository.

@wrotki
Copy link
Contributor Author

wrotki commented Mar 10, 2023

I started a cross-PR test on swiftlang/swift#64286

@wrotki wrotki merged commit 0483c3f into main Mar 14, 2023
@wrotki wrotki deleted the m_borsa_enable_driver_asan_build branch March 14, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants