Add --enable-asan option in swift-driver #64286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support building the swift-driver with -sanitize=address when the Swift build preset specifies enable-asan. Without this option and with enable-asan in picture the entire Swift build fails due to ASAN initialization failure in swift-driver. This commit is dependent on swiftlang/swift-driver#1310 being merged first rdar://104661463
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
Erm, started the test too early, missed your comment about cross-PR testing on the other commit, will retry with cross-PR |
|
preset=buildbot_incremental_asan,tools=RDA,stdlib=RDA |
|
Well, the smoke test failed, but it was ran with asan preset - and it was able to actually compile Swift and run tests, which would fail before tests phase without this fix. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
|
@swift-ci please test linux platform |
tshortli
approved these changes
Mar 14, 2023
zoecarver
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support building the swift-driver with -sanitize=address when the Swift build preset specifies enable-asan. Without this option and with enable-asan in picture the entire Swift build fails due to ASAN initialization failure in swift-driver. This commit is dependent on swiftlang/swift-driver#1310 being merged first
rdar://104661463