-
Notifications
You must be signed in to change notification settings - Fork 204
[Incremental Builds][Explicit Module Builds] Switch to using incremental dependency scanning #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Incremental Builds][Explicit Module Builds] Switch to using incremental dependency scanning #1786
Conversation
2e480bd
to
9e366d4
Compare
@swift-ci please test |
I think this PR will need the compiler change to land in a nightly snapshot first, in order to pass the tests. |
9e366d4
to
942f8f1
Compare
Shouldn't swift-driver tests work with/without swift compiler changes? It needs to handle both cases otherwise it is going to be a trouble for standalone development. |
Sources/SwiftDriver/IncrementalCompilation/FirstWaveComputer.swift
Outdated
Show resolved
Hide resolved
942f8f1
to
b700c78
Compare
@swift-ci test |
We often evolve the driver in-sync with the compiler and make inter-dependent changes between the two. The driver is tested against the current development snapshot compiler, and maintaining test compatibility with much older toolchains would be a large burden here that is not worthwhile, in my opinion. Standalone development works quite well with the same snapshot toolchains as are used in CI here. |
b700c78
to
8e9dce2
Compare
@swift-ci test |
@swift-ci test Windows platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM function wise.
…tal dependency scanning For Explicit Module Builds, have the driver configure the dependency scanner invocation to serialize its internal scanner cache state after a scan, and attempt to deserialize a prior build's scanner cache state, and validate its contents for an incremental re-scan.
8e9dce2
to
5e6a55d
Compare
@swift-ci test |
@swift-ci test Windows platform |
@swift-ci test Windows platform |
For Explicit Module Builds, have the driver configure the dependency scanner invocation to serialize its internal scanner cache state after a scan, and attempt to deserialize a prior build's scanner cache state, and validate its contents for an incremental re-scan.
Using functionality implemented in: swiftlang/swift#78962