[Dependency Scanning] Add functionality to validate contents of a loaded scanner cache state for incremental scans #78962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
IncrementalScanValidate
branch
5 times, most recently
from
bbfa13c to
a5d11e2
Compare
artemcm
commented
Jan 28, 2025
| // Initial Scan Client module | ||
| // RUN: %target-swift-frontend -scan-dependencies -scanner-module-validation -module-load-mode prefer-interface -Rdependency-scan-cache -serialize-dependency-scan-cache -dependency-scan-cache-path %t/cache.moddepcache -module-cache-path %t/module-cache %t/Client.swift -o %t/deps_initial.json -I %t/Modules -I %S/../Inputs/CHeaders -module-name Client | ||
|
|
||
| // Clean re-scan |
There was a problem hiding this comment.
Additional tests added/modified to reflect functionality introduced in this PR in swiftlang/swift-driver#1786.
|
@swift-ci test |
artemcm
requested review from
tshortli,
cachemeifyoucan,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
artemcm
force-pushed
the
IncrementalScanValidate
branch
from
a5d11e2 to
8b0d74e
Compare
|
@swift-ci test |
artemcm
force-pushed
the
IncrementalScanValidate
branch
from
8b0d74e to
59caf34
Compare
|
@swift-ci test |
artemcm
force-pushed
the
IncrementalScanValidate
branch
from
59caf34 to
5dd7bec
Compare
|
@swift-ci test |
artemcm
force-pushed
the
IncrementalScanValidate
branch
2 times, most recently
from
bd3697f to
efc9d0b
Compare
|
@swift-ci test |
artemcm
force-pushed
the
IncrementalScanValidate
branch
from
efc9d0b to
8976c80
Compare
|
@swift-ci smoke test |
…ded scanner cache state Checking each module dependency info if it is up-to-date with respect to when the cache contents were serialized in a prior scan. - Add a timestamp field to the serialization format for the dependency scanner cache - Add a flag "-validate-prior-dependency-scan-cache" which, when combined with "-load-dependency-scan-cache" will have the scanner prune dependencies from the deserialized cache which have inputs that are newer than the prior scan itself With the above in-place, the scan otherwise proceeds as-is, getting cache hits for entries still valid since the prior scan.
artemcm
force-pushed
the
IncrementalScanValidate
branch
from
8976c80 to
acb4e84
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking each module dependency info if it is up-to-date with respect to when the cache contents were serialized in a prior scan.