Skip to content

Bumped minimum platform version to 10.13 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

sstadelman
Copy link
Contributor

@sstadelman sstadelman commented Jul 28, 2020

@artemcm
Copy link
Contributor

artemcm commented Jul 28, 2020

@swift-ci please test

@artemcm artemcm self-requested a review July 28, 2020 16:28
@sstadelman
Copy link
Contributor Author

@artemcm is there another process for merging this once approved/checked?

@DougGregor DougGregor merged commit 549c96f into swiftlang:master Jul 29, 2020
@artemcm
Copy link
Contributor

artemcm commented Jul 29, 2020

@sstadelman, There is no further process.
But, I think the intent was to have this merged in tandem with the corresponding SwiftPM change (swiftlang/swift-tools-support-core#88), right?
With only this merged, and the SwiftPM piece not yet merged, SwiftPM trunk cannot be built against swift-driver trunk because:

error: the library 'Build' requires macos 10.10, but depends on the product 'SwiftDriver' which requires macos 10.13; consider changing the library 'Build' to require macos 10.13 or later, or the product 'SwiftDriver' to require macos 10.10 or earlier.

@sstadelman
Copy link
Contributor Author

@artemcm looks like it was already merged, but yes, this will have a chain effect. SPM can bump its platform minimum version, independent of the PR#88. If there's a hold on PR#88 that will be necessary.

artemcm added a commit to artemcm/swift-driver that referenced this pull request Jul 29, 2020
It was merged prematurely and is causing breaks in other projects.
artemcm added a commit that referenced this pull request Jul 29, 2020
Revert #185: Bump minimum platform version to 10.13
@sstadelman
Copy link
Contributor Author

no longer required for netrc support.

xymus pushed a commit to xymus/swift-driver that referenced this pull request Nov 6, 2020
It was merged prematurely and is causing breaks in other projects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants