Skip to content

Revert #185: Bump minimum platform version to 10.13 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 29, 2020

It was merged prematurely and is causing breaks in other projects (SwiftPM and, cascadingly, everything that relies on it).

It was merged prematurely and is causing breaks in other projects.
@artemcm
Copy link
Contributor Author

artemcm commented Jul 29, 2020

@swift-ci please test

@DougGregor
Copy link
Member

Sorry about the premature merge :(

@artemcm artemcm requested a review from DougGregor July 29, 2020 18:28
@artemcm
Copy link
Contributor Author

artemcm commented Jul 29, 2020

Sorry about the premature merge :(

No worries!

@sstadelman, please re-create the original PR and merge together with the corresponding components in SwiftPM and TSCLib.
Our CI bots have some capabilities to do cross-repository testing, if that is necessary:
https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#cross-repository-testing

@artemcm artemcm merged commit e2eca46 into swiftlang:master Jul 29, 2020
@sstadelman
Copy link
Contributor

@artemcm By 'merge together with corresponding components' I think you mean test like here?

@artemcm
Copy link
Contributor Author

artemcm commented Jul 29, 2020

@artemcm By 'merge together with corresponding components' I think you mean test like here?

For cross-repository-testing, yes, exactly like that.
But I don't know of a good mechanism in place for actual simultaneous merging after testing succeeds, though.
So it will probably have to consist of clicking multiple green buttons as "simultaneously" as possible. 😬

@artemcm artemcm deleted the DeBumpTargetPlatform branch January 20, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants