Support module wrapping for debugging on Linux #199
Merged
+119
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test Linux |
|
@swift-ci please test Linux |
|
@swift-ci please test Linux |
|
@swift-ci please test Linux |
|
@swift-ci please test Linux |
| if moduleOutputInfo.output != nil && !moduleInputs.isEmpty && compilerMode.usesPrimaryFileInputs { | ||
| jobs.append(try mergeModuleJob(inputs: moduleInputs)) | ||
| mergeJob = try mergeModuleJob(inputs: moduleInputs) |
There was a problem hiding this comment.
You won’t have to force unwrap if you store this into a separate local variable.
There was a problem hiding this comment.
I wrote it this way to mirror the usage of var link: Job? below on line 219, it might be worth cleaning both instances up as a follow-up though
|
@swift-ci test |
|
@swift-ci please test macOS |
DougGregor
approved these changes
Aug 11, 2020
|
This is breaking Swift CI (https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-18_04/8618/consoleFull#-6367346333122a513-f36a-4c87-8ed7-cbc36a1ec144): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the added tests, this fixes Driver/modulewrap.swift. I did also find a bug while working on this where we aren't always planning an autolinking job when we should. I'm pretty sure that's an unrelated issue with how we're setting the object file format of triples though.