Infer object format when it can't be determined from a triple's successfully parsed environment #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Linux |
|
Well, that broke a lot of tests 😅 |
owenv
force-pushed
the
object-format-fix
branch
from
f02904c to
6ce4bf2
Compare
|
@swift-ci please test Linux |
owenv
force-pushed
the
object-format-fix
branch
from
6ce4bf2 to
b728c09
Compare
|
@swift-ci please test Linux |
owenv
force-pushed
the
object-format-fix
branch
from
b728c09 to
017a1c4
Compare
|
@swift-ci please test Linux |
1 similar comment
|
@swift-ci please test Linux |
…ssfully parsed environment
owenv
force-pushed
the
object-format-fix
branch
from
017a1c4 to
f65f94c
Compare
|
@swift-ci please test Linux |
|
@swift-ci test |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #199, only the second commit is new.
This PR infers a triple's object format if the environment is successfully parsed but the format can't be determined from that environment. This can happen with triples like
x86_64-unknown-linux-gnuand caused autolink-extract jobs not to be generated sometimes because the object format wasn't correctly inferred as ELF. Unfortunately I had to ifdef out some tests on macOS as a result sinceswift-autolink-extractisn't available there.