Revert " Infer object format when it can't be determined from a triple's successfully parsed environment" #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e's successfully parsed environment"
|
@swift-ci test |
DougGregor
approved these changes
Aug 11, 2020
|
@DougGregor yeah, I'm pretty confused as to what happened here, I'll need to investigate this more before reapplying. Thanks for the approval! |
Swift-driver CI tested against a toolchain that did not yet contain the change that would expose this failure. Also, the test that failed is a SwiftPM test, and I don't think those run in swift-driver CI at all. As SwiftPM and swift-driver get friendlier, perhaps we should also run SwiftPM tests with the integrated driver enabled as a part of swift-driver CI. It will add some overhead to our lightning-fast CI, but it will probably be worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #201
Linux CI builds with this change are failing with "unableToFind(tool: "swift-autolink-extract")" during SMP tests. I've been unable to find the cause, so reverting for now.