Attempt to use SDKSettings.json on Darwin platforms to set -target-sdk-version #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
DougGregor
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Driver/sdk-version.swift integration test, and it's also a prerequisite to begin modernizing linker deployment targets to use -platform_version instead of the old flags.
Unfortunately, SDKSettings.json doesn't work very well with Codable synthesis and the implementation of Codable for
Versionin TSC, so there's a lot of manual decoding. Also, this implementation sometimes includes a minor version of0where the integrated driver would not (for example -target-sdk-version 13.4.0 instead of 13.4); as far as I know this won't break anything, and it makes the version remapping much simpler.