Skip to content

Use platform_version to pass deployment target information to the linker #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Aug 17, 2020

Builds on #209, only the second commit is new.

This fixes Driver/macabi-environment.swift and begins revolving some of the failures in Driver/linker.swift. It replaces the older deployment target linking flags with -platform_version.

@owenv
Copy link
Contributor Author

owenv commented Aug 17, 2020

@swift-ci test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks great, thank you!

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@owenv owenv force-pushed the linker-deployment-target branch from 7099ca2 to 12f296d Compare August 18, 2020 05:24
@owenv
Copy link
Contributor Author

owenv commented Aug 18, 2020

@swift-ci test

1 similar comment
@owenv
Copy link
Contributor Author

owenv commented Aug 19, 2020

@swift-ci test

@owenv
Copy link
Contributor Author

owenv commented Aug 21, 2020

Re-running tests before merge

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants