Skip to content

Revert "Use platform_version to pass deployment target information to the linker" #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2020
Merged

Revert "Use platform_version to pass deployment target information to the linker" #218

merged 1 commit into from
Aug 21, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Aug 21, 2020

Reverts #211

This fails on main Swift CI, not sure why yet

@owenv
Copy link
Contributor Author

owenv commented Aug 21, 2020

@swift-ci test

@owenv owenv requested review from DougGregor and artemcm August 21, 2020 15:39
@artemcm artemcm merged commit ef17783 into master Aug 21, 2020
owenv added a commit to owenv/swift-driver that referenced this pull request Aug 22, 2020
@owenv
Revert "Merge pull request swiftlang#218 from apple/revert-211-linker…
2371d20 
…-deployment-target"

This reverts commit ef17783, reversing
changes made to 124b2f6.
owenv added a commit to owenv/swift-driver that referenced this pull request Aug 23, 2020
@owenv
Revert "Merge pull request swiftlang#218 from apple/revert-211-linker…
18840d7 
…-deployment-target"

This reverts commit ef17783, reversing
changes made to 124b2f6.
owenv added a commit to owenv/swift-driver that referenced this pull request Aug 23, 2020
@owenv
Revert "Merge pull request swiftlang#218 from apple/revert-211-linker…
7f74442 
…-deployment-target"

This reverts commit ef17783, reversing
changes made to 124b2f6.
@owenv owenv deleted the revert-211-linker-deployment-target branch November 1, 2020 20:38
xymus pushed a commit to xymus/swift-driver that referenced this pull request Nov 6, 2020
@owenv @xymus
Revert "Merge pull request swiftlang#218 from apple/revert-211-linker…
5ceedca 
…-deployment-target"

This reverts commit ef17783, reversing
changes made to 124b2f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenv @artemcm