Reapply "Use platform_version to pass deployment target info to the linker" #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't acutally ready for review, CI was just having trouble cloning it and I thought marking it as ready might help |
owenv
force-pushed
the
platform-version-take-2
branch
from
2371d20 to
18840d7
Compare
owenv
force-pushed
the
platform-version-take-2
branch
from
18840d7 to
7f74442
Compare
|
@swift-ci test |
DougGregor
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to reproduce the issue that caused this to be reverted locally, so running on Swift CI to try and diagnose the problem